From 0b37a9ab0ba6f35537d2282ce4219c9c24ddf200 Mon Sep 17 00:00:00 2001 From: Bruno Trecenti Date: Wed, 22 Oct 2014 18:49:49 -0200 Subject: [PATCH] Revert "fixed fib sum, it was doing the sum for lenght + 1" This reverts commit 42530c5418df2e9a47bd8389921114d6315bea92. --- src/graphing/radar.js | 2 +- src/util/fib.js | 2 +- test/utils/fib-spec.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/graphing/radar.js b/src/graphing/radar.js index 202d1ca..4265b2a 100644 --- a/src/graphing/radar.js +++ b/src/graphing/radar.js @@ -30,7 +30,7 @@ tr.graphing.Radar = function (size, radar) { function getRadius(cycles, i) { var sequence = fib.sequence(cycles.length); - var total = fib.sum(cycles.length + 1); + var total = fib.sum(cycles.length); var sum = fib.sum(i); return center() - (center() * sum / total); diff --git a/src/util/fib.js b/src/util/fib.js index 93719bc..2170b44 100644 --- a/src/util/fib.js +++ b/src/util/fib.js @@ -15,7 +15,7 @@ tr.util.Fib = function () { if (length === 0) { return 0; } if (length === 1) { return 1; } - return self.sequence(length).reduce(function (previous, current) { + return self.sequence(length + 1).reduce(function (previous, current) { return previous + current; }, 0); }; diff --git a/test/utils/fib-spec.js b/test/utils/fib-spec.js index cdd8ac0..50d00f1 100644 --- a/test/utils/fib-spec.js +++ b/test/utils/fib-spec.js @@ -8,6 +8,6 @@ describe('tr.util.Fib', function () { it('returns the sum of a sequence', function () { var fib = new tr.util.Fib(); - expect(fib.sum(6)).toEqual(12); + expect(fib.sum(5)).toEqual(12); }); }); -- 2.39.2