From: Bruno Trecenti <btrecent@thoughtworks.com>
Date: Thu, 10 Jul 2014 12:52:18 +0000 (-0300)
Subject: fixed fib sum, it was doing the sum for lenght + 1
X-Git-Url: https://pwan.org/git/?p=tech-radar.git;a=commitdiff_plain;h=42530c5418df2e9a47bd8389921114d6315bea92

fixed fib sum, it was doing the sum for lenght + 1
---

diff --git a/src/graphing/radar.js b/src/graphing/radar.js
index 4265b2a..202d1ca 100644
--- a/src/graphing/radar.js
+++ b/src/graphing/radar.js
@@ -30,7 +30,7 @@ tr.graphing.Radar = function (size, radar) {
 
   function getRadius(cycles, i) {
     var sequence = fib.sequence(cycles.length);
-    var total = fib.sum(cycles.length);
+    var total = fib.sum(cycles.length + 1);
     var sum = fib.sum(i);
 
     return center() - (center() * sum / total);
diff --git a/src/util/fib.js b/src/util/fib.js
index 2170b44..93719bc 100644
--- a/src/util/fib.js
+++ b/src/util/fib.js
@@ -15,7 +15,7 @@ tr.util.Fib = function () {
     if (length === 0) { return 0; }
     if (length === 1) { return 1; }
 
-    return self.sequence(length + 1).reduce(function (previous, current) {
+    return self.sequence(length).reduce(function (previous, current) {
       return previous + current;
     }, 0);
   };
diff --git a/test/utils/fib-spec.js b/test/utils/fib-spec.js
index 50d00f1..cdd8ac0 100644
--- a/test/utils/fib-spec.js
+++ b/test/utils/fib-spec.js
@@ -8,6 +8,6 @@ describe('tr.util.Fib', function () {
   it('returns the sum of a sequence', function () {
     var fib = new tr.util.Fib();
 
-    expect(fib.sum(5)).toEqual(12);
+    expect(fib.sum(6)).toEqual(12);
   });
 });